fix: dashboard promote buttons disabled during deploy #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- keep promote and abort buttons enabled while deploying - disable them at all other times - also, only enable retry button when Rollout is degraded Fixes argoproj#1581 Signed-off-by: Ben Poland <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -36,6 +37,7 @@ export const RolloutActionButton = (props: {action: RolloutAction; rollout: Roll | |||
| label: 'RETRY', | |||
| icon: 'fa-redo-alt', | |||
| action: api.rolloutServiceRetryRollout, | |||
| disabled: props.rollout.status !== RolloutStatus.Degraded, | |||
There was a problem hiding this comment.
why is this added? you can retry degraded rollout as well
There was a problem hiding this comment.
Yes I think the button should only be enabled when the rollout is degraded, right? The double negative is a little confusing :)
There was a problem hiding this comment.
i misread the line..yes you are correct
harikrongali
approved these changes
Dec 22, 2021
alexmt
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1581
Signed-off-by: Ben Poland [email protected]
Checklist:
"fix(controller): Updates such and such. Fixes #1234".