-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added Argo version info in /metrics endpoint #1662
feat: added Argo version info in /metrics endpoint #1662
Conversation
Signed-off-by: Siddharth Maloo <[email protected]>
Hi @alexmt @jessesuen |
Hi, @alexmt , could you consider merging this more for the next patch release? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks go to me
controller/metrics/prommetrics.go
Outdated
Name: "argo_rollout_info", | ||
Help: "Running Argo-rollouts version", | ||
ConstLabels: prometheus.Labels{"argo_rollout_version": version.GetVersion().Version}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits:
- Can we rename this
argo_rollouts_controller_info
? Because we might have a metric endpoint for dashboard in the future and should be more specific about the component - Label can just be
version
(this is what prometheus does)
Name: "argo_rollouts_controller_info",
Help: "Running Argo-rollouts version",
ConstLabels: prometheus.Labels{"version": version.GetVersion().Version},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated as suggested. Please check
…include controller Signed-off-by: Siddharth Maloo <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## master #1662 +/- ##
==========================================
- Coverage 81.99% 81.99% -0.01%
==========================================
Files 115 116 +1
Lines 15913 15929 +16
==========================================
+ Hits 13048 13061 +13
- Misses 2196 2198 +2
- Partials 669 670 +1
Continue to review full report at Codecov.
|
Signed-off-by: Siddharth Maloo [email protected]
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.