Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Argo version info in /metrics endpoint #1662

Merged
merged 2 commits into from
Nov 19, 2021
Merged

feat: added Argo version info in /metrics endpoint #1662

merged 2 commits into from
Nov 19, 2021

Conversation

smaloo-salesforce
Copy link
Contributor

@smaloo-salesforce smaloo-salesforce commented Nov 17, 2021

Signed-off-by: Siddharth Maloo [email protected]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@smaloo-salesforce
Copy link
Contributor Author

Hi @alexmt @jessesuen
Kindly approve this one and include in upcoming release (old Reference #1600)
Thank you.

@huikang
Copy link
Member

huikang commented Nov 18, 2021

Hi, @alexmt , could you consider merging this more for the next patch release? Thanks.

Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks go to me

Comment on lines 195 to 197
Name: "argo_rollout_info",
Help: "Running Argo-rollouts version",
ConstLabels: prometheus.Labels{"argo_rollout_version": version.GetVersion().Version},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits:

  1. Can we rename this argo_rollouts_controller_info ? Because we might have a metric endpoint for dashboard in the future and should be more specific about the component
  2. Label can just be version (this is what prometheus does)
			Name:        "argo_rollouts_controller_info",
			Help:        "Running Argo-rollouts version",
			ConstLabels: prometheus.Labels{"version": version.GetVersion().Version},

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as suggested. Please check

@sonarcloud
Copy link

sonarcloud bot commented Nov 19, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #1662 (0fb93f1) into master (6edc9c8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1662      +/-   ##
==========================================
- Coverage   81.99%   81.99%   -0.01%     
==========================================
  Files         115      116       +1     
  Lines       15913    15929      +16     
==========================================
+ Hits        13048    13061      +13     
- Misses       2196     2198       +2     
- Partials      669      670       +1     
Impacted Files Coverage Δ
controller/metrics/metrics.go 100.00% <100.00%> (ø)
controller/metrics/prommetrics.go 100.00% <100.00%> (ø)
rollout/trafficrouting/istio/controller.go 50.81% <0.00%> (-1.63%) ⬇️
utils/conditions/conditions.go 80.76% <0.00%> (ø)
rollout/sync.go 78.29% <0.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6edc9c8...0fb93f1. Read the comment docs.

@jessesuen jessesuen merged commit 47d59fa into argoproj:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants