Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nginx traffic router patching wrong ingress resource #1655

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

leoluz
Copy link
Contributor

@leoluz leoluz commented Nov 12, 2021

Signed-off-by: Leonardo Luz Almeida [email protected]

Fix #1651

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@sonarcloud
Copy link

sonarcloud bot commented Nov 12, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.9% 3.9% Duplication

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #1655 (4fc115b) into master (f77b2c5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1655   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files         115      115           
  Lines       15871    15871           
=======================================
  Hits        13006    13006           
  Misses       2196     2196           
  Partials      669      669           
Impacted Files Coverage Δ
rollout/trafficrouting/nginx/nginx.go 80.19% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f77b2c5...4fc115b. Read the comment docs.

@jessesuen jessesuen merged commit 11fc42c into argoproj:master Nov 12, 2021
@leoluz leoluz added this to the v1.2 milestone Jan 27, 2022
danielm-codefresh pushed a commit to codefresh-io/argo-rollouts that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingress updater doesn't support Ingress networking.k8s.io/v1
2 participants