Add Initial Experiment Step #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Initial PR to resolve #92 |
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=========================================
+ Coverage 82.13% 82.83% +0.7%
=========================================
Files 26 27 +1
Lines 2418 2587 +169
=========================================
+ Hits 1986 2143 +157
- Misses 312 316 +4
- Partials 120 128 +8
Continue to review full report at Codecov.
|
jessesuen
approved these changes
Sep 27, 2019
pkg/apis/rollouts/v1alpha1/types.go
Outdated
| @@ -144,6 +144,48 @@ type CanaryStrategy struct { | |||
| MaxSurge *intstr.IntOrString `json:"maxSurge,omitempty"` | |||
| } | |||
|
|
|||
| // RolloutCanaryExperimentStep defines a template that is used to create a experiment for a step | |||
| type RolloutCanaryExperimentStep struct { | |||
There was a problem hiding this comment.
I can imagine a future where ExperimentStep is not just being done as part of Canary, but BlueGreen. May want to name this just RolloutExperimentStep to not box ourselves.
pkg/apis/rollouts/v1alpha1/types.go
Outdated
| } | ||
|
|
||
| //RolloutExperimentAdditionalMetadata extra labels to add to the template | ||
| type RolloutExperimentAdditionalMetadata struct { |
There was a problem hiding this comment.
How about: PodTemplateMetadata. I would make clear that this metadata will go into the labels/annotations of the actual pod
dthomson25
force-pushed
the
add-exp-step
branch
from
a54de3c to
23f51ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.