Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): DeFlake E2E Tests #1647 #1648

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

agrawroh
Copy link
Member

@agrawroh agrawroh commented Nov 11, 2021

Description

This is an attempt to fix the E2E failures by increasing the parallelism from 1 -> 4 and increasing the timeout from 20m -> 30m as we now have a lot of tests.

Checklist

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Rohit Agrawal [email protected]

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #1648 (557fb1c) into master (dc1c11b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1648   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files         115      115           
  Lines       15871    15871           
=======================================
  Hits        13006    13006           
  Misses       2196     2196           
  Partials      669      669           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc1c11b...557fb1c. Read the comment docs.

@agrawroh agrawroh force-pushed the deflake-e2e-tests branch 2 times, most recently from 0deeb82 to 0d7fae0 Compare November 11, 2021 03:57
@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.5% 6.5% Duplication

@agrawroh
Copy link
Member Author

@jessesuen This should hopefully fix things. Please feel free to assign me any E2E failure issues in case you see it after this gets merged.

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jessesuen jessesuen merged commit f77b2c5 into argoproj:master Nov 11, 2021
danielm-codefresh pushed a commit to codefresh-io/argo-rollouts that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants