fix: Route traffic to Experiment even if Canary RS not scaled #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khhirani <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1638 +/- ##
==========================================
+ Coverage 81.94% 81.96% +0.01%
==========================================
Files 115 115
Lines 15871 15900 +29
==========================================
+ Hits 13006 13032 +26
- Misses 2196 2198 +2
- Partials 669 670 +1
Continue to review full report at Codecov.
|
Signed-off-by: khhirani <[email protected]>
…to trafficrouting-exp-step-bug
Signed-off-by: khhirani <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
LGTM. There are rebase issues that I see changes not related to the code fix. Please rerun e2e tests again |
harikrongali
approved these changes
Nov 16, 2021
alexmt
approved these changes
Nov 16, 2021
johnniee
pushed a commit
to ironsource-mobile/argo-rollouts
that referenced
this pull request
Dec 29, 2021
…oj#1638) * fix: Route traffic to Experiment even if canary RS not scaled Signed-off-by: khhirani <[email protected]>
noam-codefresh
pushed a commit
to codefresh-io/argo-rollouts
that referenced
this pull request
Feb 9, 2022
…oj#1638) * fix: Route traffic to Experiment even if canary RS not scaled Signed-off-by: khhirani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1636
Signed-off-by: khhirani [email protected]