feat(alb): Surface ALB information into rollout status (#1241) #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1625 +/- ##
==========================================
+ Coverage 81.94% 81.96% +0.01%
==========================================
Files 115 115
Lines 15871 15884 +13
==========================================
+ Hits 13006 13019 +13
Misses 2196 2196
Partials 669 669
Continue to review full report at Codecov.
|
|
LGTM. Please rebase to the latest. |
pkg/apis/rollouts/v1alpha1/types.go
Outdated
| @@ -711,33 +711,35 @@ type RolloutStatus struct { | |||
| ObservedGeneration string `json:"observedGeneration,omitempty" protobuf:"bytes,13,opt,name=observedGeneration"` | |||
| // The generation of referenced workload observed by the rollout controller | |||
| // +optional | |||
| WorkloadObservedGeneration string `json:"workloadObservedGeneration,omitempty" protobuf:"bytes,24,opt,name=workloadObservedGeneration"` | |||
| WorkloadObservedGeneration string `json:"workloadObservedGeneration,omitempty" protobuf:"bytes,14,opt,name=workloadObservedGeneration"` | |||
There was a problem hiding this comment.
revert the file and move the change to the end.
harikrongali
approved these changes
Nov 15, 2021
Signed-off-by: Noam Gal <[email protected]>
Signed-off-by: Noam Gal <[email protected]>
Signed-off-by: Noam Gal <[email protected]>
Signed-off-by: Noam Gal <[email protected]>
noam-codefresh
force-pushed
the
aws_target_group_id
branch
from
74ceb64 to
2057078
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".