fix: rollout experiment template changing reference rs template labels. Fixes #1596

[flaviolemos78]

Fixes #1596

When re-creating an experiment, which has labels defined, from an already on-going canary, the GetExperimentFromTemplate is changing the experiment specRef replica set `template labels leading to errors:

time="2021-10-19T07:49:57Z" level=error msg="roCtx.reconcile err ReplicaSet.apps \"infrastructure-kubernetes-asfvalidator-74f9778454\" is invalid: spec.template.metadata.labels: Invalid value: map[string]string{\"app.kubernetes.io/instance\":\"infrastructure-kubernetes-asfvalidator-zerotraffic\", \"app.kubernetes.io/name\":\"asfvalidator-zerotraffic\", \"rollouts-pod-template-hash\":\"74f9778454\"}: `selector` does not match template `labels`" generation=31 namespace=infrastructure-kubernetes resourceVersion=253727 rollout=infrastructure-kubernetes-asfvalidator

Signed-off-by: Flavio Lemos [email protected]

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.5% Duplication

[codecov]

Codecov Report

Merging #1597 (8fd3fb2) into master (f07de59) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1597   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files         112      112           
  Lines       15117    15120    +3     
=======================================
+ Hits        12360    12363    +3     
  Misses       2110     2110           
  Partials      647      647           

Impacted Files	Coverage Δ
pkg/kubectl-argo-rollouts/cmd/get/get_rollout.go	98.49% <100.00%> (+0.01%)	⬆️
pkg/kubectl-argo-rollouts/cmd/status/status.go	93.33% <100.00%> (+0.09%)	⬆️
rollout/experiment.go	83.98% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76c1b3e...8fd3fb2. Read the comment docs.

[perenesenko]

LGTM