Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Istio Host-level TrafficRouting with experiment step #1569

Merged
merged 2 commits into from
Oct 22, 2021

Conversation

khhirani
Copy link
Contributor

@khhirani khhirani commented Oct 7, 2021

As described in comments of #1059

Signed-off-by: khhirani [email protected]

@khhirani khhirani requested a review from harikrongali October 7, 2021 17:35
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #1569 (df9890a) into master (7c77744) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1569      +/-   ##
==========================================
+ Coverage   81.76%   81.77%   +0.01%     
==========================================
  Files         112      112              
  Lines       15080    15107      +27     
==========================================
+ Hits        12330    12354      +24     
- Misses       2105     2107       +2     
- Partials      645      646       +1     
Impacted Files Coverage Δ
pkg/apis/rollouts/validation/validation.go 94.06% <100.00%> (ø)
rollout/trafficrouting/istio/istio.go 80.94% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c77744...df9890a. Read the comment docs.

@harikrongali
Copy link
Contributor

harikrongali commented Oct 7, 2021

@khhirani e2e tests are failing for istio host based tests

if len(hr) != 2 {
return fmt.Errorf("Route does not have exactly two route destinations.")
}
//if len(hr) != 2 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to remove the commented code maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for catching that!

@khhirani
Copy link
Contributor Author

khhirani commented Oct 7, 2021

@harikrongali I re-ran the workflow and all tests are passing now.

Signed-off-by: khhirani <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
3.8% 3.8% Duplication

Copy link
Member

@perenesenko perenesenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harikrongali harikrongali added the ready-for-review Ready for final review label Oct 22, 2021
Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 345b2d4 into argoproj:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants