-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Istio Host-level TrafficRouting with experiment step #1569
Conversation
Signed-off-by: khhirani <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1569 +/- ##
==========================================
+ Coverage 81.76% 81.77% +0.01%
==========================================
Files 112 112
Lines 15080 15107 +27
==========================================
+ Hits 12330 12354 +24
- Misses 2105 2107 +2
- Partials 645 646 +1
Continue to review full report at Codecov.
|
@khhirani e2e tests are failing for istio host based tests |
if len(hr) != 2 { | ||
return fmt.Errorf("Route does not have exactly two route destinations.") | ||
} | ||
//if len(hr) != 2 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to remove the commented code maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks for catching that!
@harikrongali I re-ran the workflow and all tests are passing now. |
Signed-off-by: khhirani <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As described in comments of #1059
Signed-off-by: khhirani [email protected]