Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added readthedocs configuration. Groundwork for solving #1518 #1528

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

kostis-codefresh
Copy link
Member

Signed-off-by: Kostis Kapelonis [email protected]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@kostis-codefresh
Copy link
Member Author

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #1528 (73f968d) into master (bab546d) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #1528    +/-   ##
========================================
  Coverage   81.73%   81.73%            
========================================
  Files         112      112            
  Lines       14947    15070   +123     
========================================
+ Hits        12217    12318   +101     
- Misses       2091     2107    +16     
- Partials      639      645     +6     
Impacted Files Coverage Δ
utils/defaults/defaults.go 88.02% <0.00%> (-3.64%) ⬇️
rollout/replicaset.go 67.59% <0.00%> (-3.09%) ⬇️
utils/replicaset/replicaset.go 90.04% <0.00%> (-0.83%) ⬇️
rollout/service.go 75.13% <0.00%> (ø)
utils/conditions/conditions.go 80.76% <0.00%> (ø)
rollout/trafficrouting/alb/alb.go 84.86% <0.00%> (ø)
rollout/trafficrouting/smi/smi.go 94.90% <0.00%> (ø)
rollout/trafficrouting/istio/istio.go 80.96% <0.00%> (ø)
rollout/trafficrouting/nginx/nginx.go 85.81% <0.00%> (ø)
rollout/trafficrouting/ambassador/ambassador.go 83.15% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bab546d...73f968d. Read the comment docs.

Signed-off-by: Kostis Kapelonis <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jessesuen jessesuen merged commit f07de59 into argoproj:master Oct 12, 2021
@kostis-codefresh kostis-codefresh deleted the readthedocs branch April 18, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants