Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide shell completion. Closes #619 #1478

Merged
merged 2 commits into from
Sep 13, 2021

Conversation

kostis-codefresh
Copy link
Member

@kostis-codefresh kostis-codefresh commented Sep 6, 2021

Signed-off-by: Kostis Kapelonis [email protected]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #1478 (6fc88cb) into master (ba9af78) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1478      +/-   ##
==========================================
+ Coverage   81.35%   81.43%   +0.07%     
==========================================
  Files         108      109       +1     
  Lines       14505    14564      +59     
==========================================
+ Hits        11801    11860      +59     
  Misses       2089     2089              
  Partials      615      615              
Impacted Files Coverage Δ
pkg/kubectl-argo-rollouts/cmd/cmd.go 100.00% <100.00%> (ø)
...kubectl-argo-rollouts/cmd/completion/completion.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba9af78...6fc88cb. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
35.3% 35.3% Duplication

Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Retrying e2e tests and merging once it is green.

@harikrongali harikrongali added this to the v1.1 milestone Sep 13, 2021
@alexmt alexmt merged commit ea1b8ea into argoproj:master Sep 13, 2021
@kostis-codefresh kostis-codefresh deleted the bash-completion branch April 18, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants