Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replica count for new deployment #1449

Merged
merged 4 commits into from
Aug 26, 2021

Conversation

harikrongali
Copy link
Contributor

Signed-off-by: hari rongali [email protected]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #1449 (65b7d0b) into master (7bd455f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1449      +/-   ##
==========================================
- Coverage   81.50%   81.50%   -0.01%     
==========================================
  Files         108      108              
  Lines       14153    14152       -1     
==========================================
- Hits        11536    11535       -1     
  Misses       2027     2027              
  Partials      590      590              
Impacted Files Coverage Δ
utils/replicaset/canary.go 85.18% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bd455f...65b7d0b. Read the comment docs.

Signed-off-by: hari rongali <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@alexmt alexmt merged commit ea772f7 into argoproj:master Aug 26, 2021
alexmt pushed a commit that referenced this pull request Aug 26, 2021
fix: replica count for new deployment (#1449)

Signed-off-by: hari rongali <[email protected]>
jessesuen added a commit to jessesuen/argo-rollouts that referenced this pull request Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants