fix: Analysis argument validation

[khhirani]

Fixes #1358

[khhirani]

@harikrongali Please review when you get a chance

[codecov]

Codecov Report

Merging #1412 (57eae70) into master (f9d2940) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1412      +/-   ##
==========================================
- Coverage   81.54%   81.46%   -0.08%     
==========================================
  Files         108      108              
  Lines       10104    10124      +20     
==========================================
+ Hits         8239     8248       +9     
- Misses       1304     1312       +8     
- Partials      561      564       +3     

Impacted Files	Coverage Δ
analysis/analysis.go	83.65% <100.00%> (-2.23%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d2940...57eae70. Read the comment docs.

[jessesuen]

Does this need to be cherry picked to v1.0.x?

[harikrongali]

args for count is not working.https://github.com/argoproj/argo-rollouts/blob/986d4b045ddd2d604bdf8e372dedb40914b37717/pkg/apis/rollouts/v1alpha1/openapi_generated.go

--- ignore the issue as the validation coming from API and for now there is workaround where default value can be replaced from rollout.

[harikrongali]

added e2e tests in khhirani#111 . please verify the E2e tests. Other than that changes looks good

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
6.9% Duplication

[harikrongali]

approve. LGTM

[alexmt]

LGTM.

Tested manually as well with the example provided in the issue - no validation errors