feat: add support for Graphite metrics provider #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdb
force-pushed
the
1403-graphite-metrics-provider
branch
from
8815bce to
10cbafc
Compare
Address issue argoproj#1403 by adding a Graphite metrics provider. Signed-off-by: Mike Ball <[email protected]>
mdb
force-pushed
the
1403-graphite-metrics-provider
branch
from
10cbafc to
8f4eb59
Compare
Signed-off-by: Mike Ball <[email protected]>
mdb
force-pushed
the
1403-graphite-metrics-provider
branch
from
007a999 to
d1c71ac
Compare
jessesuen
reviewed
Aug 24, 2021
Codecov Report
@@ Coverage Diff @@
## master #1406 +/- ##
==========================================
+ Coverage 81.67% 81.73% +0.06%
==========================================
Files 110 112 +2
Lines 14798 14947 +149
==========================================
+ Hits 12086 12217 +131
- Misses 2078 2091 +13
- Partials 634 639 +5
Continue to review full report at Codecov.
|
Signed-off-by: Mike Ball <[email protected]>
Signed-off-by: Mike Ball <[email protected]>
Per code review feedback... > It's a bad idea to use the golang HTTP default client because of possibility of hung connections, since it does not timeout As outlined here: https://medium.com/@nate510/don-t-use-go-s-default-http-client-4804cb19f779 The 10s timeout matches the default of the webmetric provider's HTTP client. Signed-off-by: Mike Ball <[email protected]>
Signed-off-by: Mike Ball <[email protected]>
mdb
added a commit
to mdb/argo-rollouts
that referenced
this pull request
Aug 27, 2021
Previously, `graphite.API#Query` returned the value of the last item in the `datapoints` array returned by the Graphite API. However, this somewhat diverged from the Prometheus metricprovider implementation and fails to consider a use case for obtaining the first or an arbitrary element from the datapoints array, as discussed here: argoproj#1406 (comment) Signed-off-by: Mike Ball <[email protected]>
Previously, `graphite.API#Query` returned the value of the last item in the `datapoints` array returned by the Graphite API. However, this somewhat diverged from the Prometheus metricprovider implementation and fails to consider a use case for obtaining the first or an arbitrary element from the datapoints array, as discussed here: argoproj#1406 (comment) Signed-off-by: Mike Ball <[email protected]>
mdb
force-pushed
the
1403-graphite-metrics-provider
branch
from
b4ca2de to
91e32aa
Compare
Signed-off-by: Mike Ball <[email protected]>
Signed-off-by: Mike Ball <[email protected]>
mdb
force-pushed
the
1403-graphite-metrics-provider
branch
from
049c1aa to
cb56197
Compare
Signed-off-by: Mike Ball <[email protected]>
…cs-provider Signed-off-by: Mike Ball <[email protected]>
|
@jessesuen Thanks for your patience. I'm curious to hear your feedback on my latest commits. Have I addressed your concerns? |
|
@mdb can you please rebase to latest master |
Signed-off-by: Jesse Suen <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #1403 by adding a Graphite metrics provider.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".