Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nil pointer in create analysisrun cmd #1399

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

huikang
Copy link
Member

@huikang huikang commented Aug 9, 2021

Signed-off-by: Hui Kang [email protected]

Checklist:

fix #1398

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #1399 (9d6b3c9) into master (2620490) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1399      +/-   ##
==========================================
+ Coverage   81.22%   81.27%   +0.05%     
==========================================
  Files         108      108              
  Lines        9916     9951      +35     
==========================================
+ Hits         8054     8088      +34     
  Misses       1309     1309              
- Partials      553      554       +1     
Impacted Files Coverage Δ
pkg/kubectl-argo-rollouts/cmd/create/create.go 65.58% <100.00%> (+0.16%) ⬆️
rollout/analysis.go 80.75% <100.00%> (+0.14%) ⬆️
rollout/experiment.go 85.71% <100.00%> (+0.18%) ⬆️
utils/analysis/filter.go 97.93% <100.00%> (+0.46%) ⬆️
utils/defaults/defaults.go 92.00% <100.00%> (+0.69%) ⬆️
utils/experiment/filter.go 100.00% <100.00%> (ø)
rollout/canary.go 76.41% <0.00%> (-2.06%) ⬇️
rollout/bluegreen.go 70.91% <0.00%> (ø)
rollout/sync.go 76.63% <0.00%> (+0.16%) ⬆️
pkg/apis/rollouts/validation/validation.go 97.14% <0.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffe70da...9d6b3c9. Read the comment docs.

@jessesuen jessesuen merged commit 53b1996 into argoproj:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubectl argo rollouts create analysisrun segfaults
2 participants