Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undo referenced object for workloadRef rollout #1275

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

huikang
Copy link
Member

@huikang huikang commented Jun 14, 2021

  • rollback by patching the referenceed object, e.g., deployment, replicaset
  • unit test is added

close #1254

Signed-off-by: Hui Kang [email protected]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@huikang huikang force-pushed the 1254-undo-workloadRef branch from daf51d2 to 431c846 Compare June 14, 2021 05:01
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #1275 (d7df29f) into master (fe4bb1b) will decrease coverage by 0.05%.
The diff coverage is 68.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1275      +/-   ##
==========================================
- Coverage   81.35%   81.30%   -0.06%     
==========================================
  Files         106      106              
  Lines        9597     9618      +21     
==========================================
+ Hits         7808     7820      +12     
- Misses       1260     1268       +8     
- Partials      529      530       +1     
Impacted Files Coverage Δ
pkg/kubectl-argo-rollouts/cmd/undo/undo.go 74.34% <68.18%> (-0.47%) ⬇️
rollout/controller.go 77.57% <0.00%> (-0.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe4bb1b...d7df29f. Read the comment docs.

@huikang huikang force-pushed the 1254-undo-workloadRef branch 3 times, most recently from 73a4cad to 72ee737 Compare June 15, 2021 03:25
- unit test is added

Signed-off-by: Hui Kang <[email protected]>
@huikang huikang force-pushed the 1254-undo-workloadRef branch from 72ee737 to d7df29f Compare June 15, 2021 03:58
@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
6.4% 6.4% Duplication

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollback a canary deployment when using workoadRef
2 participants