-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Istio multicluster setup. Fixes #1191. #1274
Merged
jessesuen
merged 7 commits into
argoproj:master
from
shakti-das:shakti/istio-multicluster
Jul 8, 2021
+275
−9
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
dd74ab0
Initial working code
shakti-das 016e103
Refactor, add tests
shakti-das e060855
Add organization to users.md
shakti-das 20d1aa2
Refactor test
shakti-das a76373d
Update docs for enabling Argo Rollouts in Istio multicluster setup
shakti-das a39e1b5
Address review comments
shakti-das ba80df2
gofmt -s -w new files
shakti-das File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update docs for enabling Argo Rollouts in Istio multicluster setup
Signed-off-by: Shakti <shaktiprakash.das@salesforce.com>
commit a76373d0684b0f0b39420c2f86f4330507965068
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default role in the manifest folder should be good
argo-rollouts/manifests/role/argo-rollouts-clusterrole.yaml
Lines 139 to 150 in 460262e
Could you put a note there so that user doesn't need to create extra clusterrole.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. If Argo controller is also installed in the primary cluster (not mandatory), then we could just use the default
argo-rollouts-clusterrole
instead of creating another in the primary cluster. I will add a note to mention the same. Thanks.