Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix error check in validation for AnalysisTemplates not found #1249

Merged

Conversation

khhirani
Copy link
Contributor

@khhirani khhirani commented Jun 3, 2021

Closes #1248

@khhirani khhirani requested a review from jessesuen June 3, 2021 03:19
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #1249 (d595c25) into master (ccff157) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1249      +/-   ##
==========================================
+ Coverage   81.29%   81.39%   +0.09%     
==========================================
  Files         106      106              
  Lines        9522     9522              
==========================================
+ Hits         7741     7750       +9     
+ Misses       1256     1251       -5     
+ Partials      525      521       -4     
Impacted Files Coverage Δ
rollout/controller.go 78.44% <100.00%> (+2.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccff157...d595c25. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jessesuen jessesuen merged commit c68f3df into argoproj:master Jun 3, 2021
caoyang001 pushed a commit to caoyang001/argo-rollouts that referenced this pull request Jun 12, 2021
huikang pushed a commit to huikang/argo-rollouts that referenced this pull request Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid memory address or nil pointer dereference in getReferencedRolloutAnalyses()
2 participants