Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate skip-current-step command #1156

Merged
merged 6 commits into from
May 14, 2021

Conversation

harikrongali
Copy link
Contributor

@harikrongali harikrongali commented May 10, 2021

Checklist:

  • Resolves Simplify plugin promote options (deprecate --skip-current-step) #1142.
  • [X ] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • [X ] I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #1156 (fbd0591) into master (f5e2d82) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1156      +/-   ##
==========================================
- Coverage   81.02%   81.01%   -0.01%     
==========================================
  Files         105      105              
  Lines        9396     9404       +8     
==========================================
+ Hits         7613     7619       +6     
- Misses       1264     1265       +1     
- Partials      519      520       +1     
Impacted Files Coverage Δ
pkg/kubectl-argo-rollouts/cmd/promote/promote.go 93.90% <75.00%> (-2.05%) ⬇️
rollout/pause.go 95.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5e2d82...fbd0591. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented May 14, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.4% 4.4% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants