Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround K8s inability to properly validate 'items' subfields #114

Merged
merged 1 commit into from
Jun 26, 2019

Conversation

jessesuen
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #114 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #114   +/-   ##
======================================
  Coverage    79.2%   79.2%           
======================================
  Files          15      15           
  Lines        1842    1842           
======================================
  Hits         1459    1459           
  Misses        283     283           
  Partials      100     100

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b1b31...a6bbe0b. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #114 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #114   +/-   ##
======================================
  Coverage    79.2%   79.2%           
======================================
  Files          15      15           
  Lines        1842    1842           
======================================
  Hits         1459    1459           
  Misses        283     283           
  Partials      100     100

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b1b31...a6bbe0b. Read the comment docs.

@jessesuen jessesuen requested a review from dthomson25 June 26, 2019 05:41
Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dthomson25 dthomson25 merged commit e08c4dd into argoproj:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants