Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add RolloutCompleted condition #1074

Merged
merged 13 commits into from
Apr 20, 2021

Conversation

khhirani
Copy link
Contributor

@khhirani khhirani commented Apr 8, 2021

Closes #352

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any tests. Can you add a unit test for this as well as enhance the e2e test you added earlier for this?

Signed-off-by: khhirani <[email protected]>
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #1074 (8174791) into master (0f131a7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1074      +/-   ##
==========================================
+ Coverage   81.22%   81.24%   +0.01%     
==========================================
  Files         103      103              
  Lines        9252     9261       +9     
==========================================
+ Hits         7515     7524       +9     
  Misses       1235     1235              
  Partials      502      502              
Impacted Files Coverage Δ
utils/conditions/conditions.go 78.72% <ø> (ø)
rollout/sync.go 75.25% <100.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f131a7...8174791. Read the comment docs.

@khhirani khhirani requested a review from jessesuen April 14, 2021 03:54
@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
4.5% 4.5% Duplication

@khhirani khhirani merged commit 7ad745a into argoproj:master Apr 20, 2021
@khhirani khhirani deleted the add-ro-complete-cond branch April 20, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add conditions to allow to wait for rollout pauses & completions
2 participants