-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add RolloutCompleted condition #1074
Conversation
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
…to add-ro-complete-cond
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any tests. Can you add a unit test for this as well as enhance the e2e test you added earlier for this?
Signed-off-by: khhirani <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1074 +/- ##
==========================================
+ Coverage 81.22% 81.24% +0.01%
==========================================
Files 103 103
Lines 9252 9261 +9
==========================================
+ Hits 7515 7524 +9
Misses 1235 1235
Partials 502 502
Continue to review full report at Codecov.
|
Signed-off-by: khhirani <[email protected]>
…to add-ro-complete-cond
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Closes #352