-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create RolloutPaused condition #1054
Conversation
Signed-off-by: khhirani <[email protected]>
dec15f9
to
0083317
Compare
Signed-off-by: khhirani <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1054 +/- ##
==========================================
+ Coverage 80.90% 81.02% +0.11%
==========================================
Files 103 103
Lines 9104 9174 +70
==========================================
+ Hits 7366 7433 +67
- Misses 1244 1246 +2
- Partials 494 495 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any new unit tests which test this new feature.
Can we also have an e2e test that uses kubectl wait
to verify it end-to-end?
@jessesuen Do we need new unit tests for this feature? I thought the change was sufficiently covered by the existing tests after I modified them, but I can add new ones if you think we need them. |
Signed-off-by: khhirani <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Closes #352