Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blue-green rollouts could pause prematurely during prePromotionAnalysis #1007

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

jessesuen
Copy link
Member

Resolves #990

Fixes an issue where blue-green would be paused prematurely during prePromotionAnalysis.

Signed-off-by: Jesse Suen [email protected]

@jessesuen jessesuen changed the title blue-green rollouts could pause prematurely during prePromotionAnalysis fix: blue-green rollouts could pause prematurely during prePromotionAnalysis Feb 24, 2021
@codecov-io
Copy link

Codecov Report

Merging #1007 (2351446) into master (bbd7768) will decrease coverage by 0.07%.
The diff coverage is 78.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1007      +/-   ##
==========================================
- Coverage   80.98%   80.90%   -0.08%     
==========================================
  Files         102      102              
  Lines        9072     9093      +21     
==========================================
+ Hits         7347     7357      +10     
- Misses       1233     1241       +8     
- Partials      492      495       +3     
Impacted Files Coverage Δ
rollout/bluegreen.go 70.56% <73.52%> (-1.48%) ⬇️
rollout/pause.go 97.00% <83.33%> (-1.98%) ⬇️
rollout/canary.go 83.55% <100.00%> (ø)
rollout/service.go 74.28% <100.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbd7768...2351446. Read the comment docs.

hack/update-manifests.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@khhirani khhirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
9.3% 9.3% Duplication

@jessesuen jessesuen merged commit f0d39d9 into argoproj:master Feb 25, 2021
@jessesuen jessesuen deleted the bg-double-pause branch February 25, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blue-green rollouts could pause prematurely during prePromotionAnalysis
3 participants