-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement rollout status command. Fixes #596 #1001
feat: Implement rollout status command. Fixes #596 #1001
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1001 +/- ##
==========================================
+ Coverage 80.90% 81.00% +0.09%
==========================================
Files 102 103 +1
Lines 9080 9159 +79
==========================================
+ Hits 7346 7419 +73
- Misses 1240 1245 +5
- Partials 494 495 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this, I think this is the best I can offer as feedback. Someone more core should be responsible for a code review & approval
Signed-off-by: Pedro Arvela <[email protected]>
Signed-off-by: Pedro Arvela <[email protected]>
Signed-off-by: Pedro Arvela <[email protected]>
Signed-off-by: Pedro Arvela <[email protected]>
Signed-off-by: Pedro Arvela <[email protected]>
Signed-off-by: Pedro Arvela <[email protected]>
Signed-off-by: Pedro Arvela <[email protected]>
Signed-off-by: Pedro Arvela <[email protected]>
Signed-off-by: Pedro Arvela <[email protected]>
Signed-off-by: Pedro Arvela <[email protected]>
Is there anything preventing this from being merged? This would be huge for my organization's CD pipeline |
It seems that kubectl defaults to at timeout of 0s (never). Instead of defaulting to 5m, can we replicate kubectl behavior?
|
I must have misread when I saw the timeout default. I'll update it to replicate that default. |
Signed-off-by: Pedro Arvela <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Fixed the timeout to match the official one in kubectl itself. |
Great work! |
When will it be available for use? |
Closes #596
This replicates the
kubectl rollout status deployment [--watch] <name>
command, but for Rollouts.This is implemented as:
The flags and defaults for them replicate the
kubectl rollout status deployment <name>
command. As in it,--watch
is default and the default timeout is 5 minutes.Checklist:
(b) this is a bug fix, or (c) this is a chore."fix(controller): Updates such and such. Fixes #1234"
.