Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move ReplicaSet creation and Rollout validation earlier during the reconciliation process. #3657

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Jun 20, 2024

There are 3 main changes in this PR:

  1. Move Rollouts validation up earlier in the reconcile process into the rollout context creation function.
  2. Move replica set creation code up earlier in the reconciliation process into the rollout context creation function.
  3. Change replica set creation so that it dose not depend on the calling code to pass a bool into the function but instead automatically determines if replica sets need to be created.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.76%. Comparing base (36b9e15) to head (8c0e048).
Report is 63 commits behind head on master.

Files with missing lines Patch % Lines
rollout/controller.go 85.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3657       +/-   ##
===========================================
+ Coverage        0   83.76%   +83.76%     
===========================================
  Files           0      162      +162     
  Lines           0    18515    +18515     
===========================================
+ Hits            0    15509    +15509     
- Misses          0     2131     +2131     
- Partials        0      875      +875     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@zachaller zachaller force-pushed the fix-rs-conflict-with-fallback-to-patch-replicaset-refactor branch from 96f68ab to 49809f6 Compare June 27, 2024 17:05
@argoproj argoproj deleted a comment from github-actions bot Jul 24, 2024
@argoproj argoproj deleted a comment from github-actions bot Jul 24, 2024
Copy link
Contributor

github-actions bot commented Jul 25, 2024

Published E2E Test Results

  4 files    4 suites   3h 20m 46s ⏱️
113 tests 100 ✅  7 💤 6 ❌
458 runs  424 ✅ 28 💤 6 ❌

For more details on these failures, see this check.

Results for commit 8c0e048.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 25, 2024

Published Unit Test Results

2 256 tests   2 256 ✅  2m 58s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit 8c0e048.

♻️ This comment has been updated with latest results.

@argoproj argoproj deleted a comment from github-actions bot Jul 25, 2024
@zachaller zachaller marked this pull request as ready for review July 30, 2024 14:37
@zachaller zachaller changed the title chore: possible RS refactor chore: ReplicaSet creation refactor Aug 9, 2024
@zachaller zachaller force-pushed the fix-rs-conflict-with-fallback-to-patch-replicaset-refactor branch from 0e859c3 to 3f1e1e0 Compare August 13, 2024 14:22
…s-conflict-with-fallback-to-patch-replicaset-refactor
…s-conflict-with-fallback-to-patch-replicaset-refactor
Copy link

sonarcloud bot commented Aug 14, 2024

rollout/context.go Show resolved Hide resolved
rollout/service.go Show resolved Hide resolved
@zachaller zachaller changed the title chore: ReplicaSet creation refactor chore: move ReplicaSet creation earlier during the reconciliation processes and change when validation happens. Aug 15, 2024
@zachaller zachaller changed the title chore: move ReplicaSet creation earlier during the reconciliation processes and change when validation happens. chore: move ReplicaSet creation earlier during the reconciliation process and change when validation happens. Aug 15, 2024
@zachaller zachaller changed the title chore: move ReplicaSet creation earlier during the reconciliation process and change when validation happens. chore: move ReplicaSet creation and Rollout validation earlier during the reconciliation process. Aug 15, 2024
Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller zachaller merged commit 7938e84 into argoproj:master Aug 26, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants