Skip to content

Commit

Permalink
re-name
Browse files Browse the repository at this point in the history
Signed-off-by: Zach Aller <[email protected]>
  • Loading branch information
zachaller committed Aug 12, 2024
1 parent e613387 commit 0e859c3
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions rollout/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -483,15 +483,15 @@ func (c *Controller) writeBackToInformer(ro *v1alpha1.Rollout) {
}

func (c *Controller) newRolloutContext(rollout *v1alpha1.Rollout) (*rolloutContext, error) {
rsListForRollout, err := c.getReplicaSetsForRollouts(rollout)
rsList, err := c.getReplicaSetsForRollouts(rollout)
if err != nil {
return nil, err
}

newRS := replicasetutil.FindNewReplicaSet(rollout, rsListForRollout)
olderRSs := replicasetutil.FindOldReplicaSets(rollout, rsListForRollout, newRS)
newRS := replicasetutil.FindNewReplicaSet(rollout, rsList)
olderRSs := replicasetutil.FindOldReplicaSets(rollout, rsList, newRS)
stableRS := replicasetutil.GetStableRS(rollout, newRS, olderRSs)
otherRSs := replicasetutil.GetOtherRSs(rollout, newRS, stableRS, rsListForRollout)
otherRSs := replicasetutil.GetOtherRSs(rollout, newRS, stableRS, rsList)

exList, err := c.getExperimentsForRollout(rollout)
if err != nil {
Expand All @@ -514,7 +514,7 @@ func (c *Controller) newRolloutContext(rollout *v1alpha1.Rollout) (*rolloutConte
stableRS: stableRS,
olderRSs: olderRSs,
otherRSs: otherRSs,
allRSs: rsListForRollout,
allRSs: rsList,
currentArs: currentArs,
otherArs: otherArs,
currentEx: currentEx,
Expand Down Expand Up @@ -556,10 +556,10 @@ func (c *Controller) newRolloutContext(rollout *v1alpha1.Rollout) (*rolloutConte
if err != nil {
return nil, err
}
roCtx.olderRSs = replicasetutil.FindOldReplicaSets(roCtx.rollout, rsListForRollout, roCtx.newRS)
roCtx.olderRSs = replicasetutil.FindOldReplicaSets(roCtx.rollout, rsList, roCtx.newRS)
roCtx.stableRS = replicasetutil.GetStableRS(roCtx.rollout, roCtx.newRS, roCtx.olderRSs)
roCtx.otherRSs = replicasetutil.GetOtherRSs(roCtx.rollout, roCtx.newRS, roCtx.stableRS, rsListForRollout)
roCtx.allRSs = append(rsListForRollout, roCtx.newRS)
roCtx.otherRSs = replicasetutil.GetOtherRSs(roCtx.rollout, roCtx.newRS, roCtx.stableRS, rsList)
roCtx.allRSs = append(rsList, roCtx.newRS)
err := roCtx.replicaSetInformer.GetIndexer().Add(roCtx.newRS)
if err != nil {
return nil, err

Check warning on line 565 in rollout/controller.go

View check run for this annotation

Codecov / codecov/patch

rollout/controller.go#L565

Added line #L565 was not covered by tests
Expand Down

0 comments on commit 0e859c3

Please sign in to comment.