Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typo for json tag on rollbackWindow #2598

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

zachaller
Copy link
Collaborator

fixes: #2568

Signed-off-by: zachaller <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.3% 2.3% Duplication

@zachaller zachaller requested a review from leoluz February 16, 2023 21:15
Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Go Published Test Results

1 850 tests   1 850 ✔️  2m 30s ⏱️
   112 suites         0 💤
       1 files           0

Results for commit c714cc9.

@github-actions
Copy link
Contributor

E2E Tests Published Test Results

    2 files      2 suites   1h 44m 27s ⏱️
  96 tests   85 ✔️ 3 💤 8
200 runs  186 ✔️ 6 💤 8

For more details on these failures, see this check.

Results for commit c714cc9.

@zachaller zachaller merged commit 4afac4e into argoproj:master Feb 16, 2023
chatchai-outreach pushed a commit to getoutreach/argoproj-argo-rollouts that referenced this pull request Feb 21, 2023
@zachaller zachaller added cherry-pick/release-1.4 cherry-pick-completed Used once we have cherry picked the PR to all requested releases labels Feb 24, 2023
zachaller added a commit that referenced this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-1.4 cherry-pick-completed Used once we have cherry picked the PR to all requested releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argo Rollout RollbackWindow property is NOT optional as documented.
2 participants