Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing metric for updatedReplicas #2297

Closed
zachaller opened this issue Oct 7, 2022 · 1 comment
Closed

Missing metric for updatedReplicas #2297

zachaller opened this issue Oct 7, 2022 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Milestone
v1.4

Comments

@zachaller
Copy link
Collaborator

zachaller commented Oct 7, 2022 •
edited
Loading

Describe the bug

We currently expose status.availableReplicas and status.readyReplicas but we are missing status.updatedReplicas we should also expose status.updatedReplicasas a prometheus metric.

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.
@zachaller zachaller added bug Something isn't working good first issue Good for newcomers hacktoberfest labels Oct 7, 2022
@nitram509
Copy link
Contributor

✋ will pick this one :)

nitram509 added a commit to nitram509/argo-rollouts that referenced this issue Oct 7, 2022
@nitram509
fix issue argoproj#2297 Missing metric for updatedReplicas
517ff0d 
incl. documentation and enhanced test
incl. fix rollout_info_replicas_desired was not documented
nitram509 added a commit to nitram509/argo-rollouts that referenced this issue Oct 7, 2022
@nitram509
fix issue argoproj#2297 Missing metric for updatedReplicas
d9b754a 
incl. documentation and enhanced test
incl. fix rollout_info_replicas_desired was not documented

Signed-off-by: nitram509 <[email protected]>
@harikrongali harikrongali added this to the v1.4 milestone Oct 20, 2022
zachaller added a commit that referenced this issue Nov 8, 2022
@nitram509 @zachaller
fix issue #2297 Missing metric for updatedReplicas (#2300)
3aa87aa 
incl. documentation and enhanced test
incl. fix rollout_info_replicas_desired was not documented

Signed-off-by: nitram509 <[email protected]>

Signed-off-by: nitram509 <[email protected]>
Signed-off-by: zachaller <[email protected]>
Co-authored-by: zachaller <[email protected]>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this issue Nov 8, 2022
@nitram509 @zachaller @jandersen-plaid
fix issue argoproj#2297 Missing metric for updatedReplicas (argoproj#…
fce9d2d 
…2300)

incl. documentation and enhanced test
incl. fix rollout_info_replicas_desired was not documented

Signed-off-by: nitram509 <[email protected]>

Signed-off-by: nitram509 <[email protected]>
Signed-off-by: zachaller <[email protected]>
Co-authored-by: zachaller <[email protected]>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this issue Nov 26, 2022
@nitram509 @zachaller @jandersen-plaid
fix issue argoproj#2297 Missing metric for updatedReplicas (argoproj#…
c5399f9 
…2300)

incl. documentation and enhanced test
incl. fix rollout_info_replicas_desired was not documented

Signed-off-by: nitram509 <[email protected]>

Signed-off-by: nitram509 <[email protected]>
Signed-off-by: zachaller <[email protected]>
Co-authored-by: zachaller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
v1.4
Development

No branches or pull requests
3 participants
@zachaller @nitram509 @harikrongali