New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI not setting correct mime type #2290

Closed

zachaller opened this issue Oct 6, 2022 · 1 comment

Labels

bug good first issue hacktoberfest

Milestone

Collaborator

zachaller commented Oct 6, 2022 •

edited

Loading

The UI is not sending the correct mime types and is responding to things like JS files etc as plain/text

zachaller added bug good first issue hacktoberfest labels

Contributor

nitram509 commented Oct 8, 2022

👋 will work on it and provide a PR within the next 48h

nitram509 mentioned this issue

fix(dashboard): correct mime type is returned. Fixes: #2290 #2303

Merged

6 tasks

harikrongali added this to the v1.4 milestone

zachaller closed this as completed in

32dea1a

jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this issue


          fix(dashboard): correct mime type is returned. Fixes: argoproj#2290 (a…

5896e89

…rgoproj#2303)

* fix: correct mimetype is returned
fix: when request /index.html, base path was not modified
fix: wrong 'err' variable used when log.Errorf("Failed to stat file or dir %s: %v"...) was printed
change: when a file is not found, 404 is return (before: the index.html was returned)
add: tests for static files serving

Signed-off-by: nitram509 <[email protected]>

* fix sonar cloud complains about invalid HTML
See https://sonarcloud.io/project/issues?resolved=false&types=BUG&pullRequest=2303&id=argoproj_argo-rollouts&open=AYO5y8lxtb83AIZrmShZ

Signed-off-by: nitram509 <[email protected]>

* fix send index.html when page not found, because client side React UI router

Signed-off-by: nitram509 <[email protected]>

* make variable private (feedback from review)

Signed-off-by: nitram509 <[email protected]>

Signed-off-by: nitram509 <[email protected]>

jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this issue


          fix(dashboard): correct mime type is returned. Fixes: argoproj#2290 (a…

a1ab16a

…rgoproj#2303)

* fix: correct mimetype is returned
fix: when request /index.html, base path was not modified
fix: wrong 'err' variable used when log.Errorf("Failed to stat file or dir %s: %v"...) was printed
change: when a file is not found, 404 is return (before: the index.html was returned)
add: tests for static files serving

Signed-off-by: nitram509 <[email protected]>

* fix sonar cloud complains about invalid HTML
See https://sonarcloud.io/project/issues?resolved=false&types=BUG&pullRequest=2303&id=argoproj_argo-rollouts&open=AYO5y8lxtb83AIZrmShZ

Signed-off-by: nitram509 <[email protected]>

* fix send index.html when page not found, because client side React UI router

Signed-off-by: nitram509 <[email protected]>

* make variable private (feedback from review)

Signed-off-by: nitram509 <[email protected]>

Signed-off-by: nitram509 <[email protected]>

zachaller pushed a commit that referenced this issue


          fix(dashboard): correct mime type is returned. Fixes: #2290 (#2303)

dcd20ad

* fix: correct mimetype is returned
fix: when request /index.html, base path was not modified
fix: wrong 'err' variable used when log.Errorf("Failed to stat file or dir %s: %v"...) was printed
change: when a file is not found, 404 is return (before: the index.html was returned)
add: tests for static files serving

Signed-off-by: nitram509 <[email protected]>

* fix sonar cloud complains about invalid HTML
See https://sonarcloud.io/project/issues?resolved=false&types=BUG&pullRequest=2303&id=argoproj_argo-rollouts&open=AYO5y8lxtb83AIZrmShZ

Signed-off-by: nitram509 <[email protected]>

* fix send index.html when page not found, because client side React UI router

Signed-off-by: nitram509 <[email protected]>

* make variable private (feedback from review)

Signed-off-by: nitram509 <[email protected]>

Signed-off-by: nitram509 <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment