Skip to content

Commit

Permalink
update comments
Browse files Browse the repository at this point in the history
Signed-off-by: zachaller <[email protected]>
  • Loading branch information
zachaller committed Apr 7, 2023
1 parent e3a4fba commit 5c1b63f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion rollout/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,8 @@ func (c *Controller) syncHandler(ctx context.Context, key string) error {
logCtx.Errorf("roCtx.reconcile err %v", err)
// return an err here so that we do not update the informer cache with a "bad" rollout object, for the case when
// we get an error during reconciliation but c.newRollout still gets updated this can happen in syncReplicaSetRevision
// https://github.com/argoproj/argo-rollouts/issues/2522#issuecomment-1492181154
// https://github.com/argoproj/argo-rollouts/issues/2522#issuecomment-1492181154 I also believe there are other cases
// that newRollout can get updated while we get an error during reconciliation
return err
}
if roCtx.newRollout != nil {
Expand Down

0 comments on commit 5c1b63f

Please sign in to comment.