Skip to content

Commit

Permalink
chore: capitalize AS in Dockerfile (#3781)
Browse files Browse the repository at this point in the history
Signed-off-by: Kevin Ji <[email protected]>
  • Loading branch information
kevinji authored Aug 12, 2024
1 parent 825a7ca commit 54cef88
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Initial stage which pulls prepares build dependencies and CLI tooling we need for our final image
# Also used as the image in CI jobs so needs all dependencies
####################################################################################################
FROM --platform=$BUILDPLATFORM golang:1.22 as builder
FROM --platform=$BUILDPLATFORM golang:1.22 AS builder

RUN apt-get update && apt-get install -y \
wget \
Expand All @@ -24,7 +24,7 @@ RUN cd ${GOPATH}/src/dummy && \
####################################################################################################
# UI build stage
####################################################################################################
FROM --platform=$BUILDPLATFORM docker.io/library/node:18 as argo-rollouts-ui
FROM --platform=$BUILDPLATFORM docker.io/library/node:18 AS argo-rollouts-ui

WORKDIR /src
ADD ["ui/package.json", "ui/yarn.lock", "./"]
Expand All @@ -40,7 +40,7 @@ RUN NODE_ENV='production' yarn build
####################################################################################################
# Rollout Controller Build stage which performs the actual build of argo-rollouts binaries
####################################################################################################
FROM --platform=$BUILDPLATFORM golang:1.22 as argo-rollouts-build
FROM --platform=$BUILDPLATFORM golang:1.22 AS argo-rollouts-build

WORKDIR /go/src/github.com/argoproj/argo-rollouts

Expand Down Expand Up @@ -69,7 +69,7 @@ RUN GOOS=$TARGETOS GOARCH=$TARGETARCH make ${MAKE_TARGET}
####################################################################################################
# Kubectl plugin image
####################################################################################################
FROM gcr.io/distroless/static-debian11 as kubectl-argo-rollouts
FROM gcr.io/distroless/static-debian11 AS kubectl-argo-rollouts

COPY --from=argo-rollouts-build /go/src/github.com/argoproj/argo-rollouts/dist/kubectl-argo-rollouts /bin/kubectl-argo-rollouts

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.dev
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
####################################################################################################
# argo-rollouts-dev
####################################################################################################
FROM golang:1.20 as builder
FROM golang:1.20 AS builder

RUN apt-get update && apt-get install -y \
ca-certificates && \
Expand Down

0 comments on commit 54cef88

Please sign in to comment.