fix(analysis): Graphite query - remove whitespaces

Signed-off-by: mdsjip <[email protected]>
argoproj · May 6, 2023 · 489053e · 489053e
1 parent c74c464
commit 489053e
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/metricproviders/graphite/api.go b/metricproviders/graphite/api.go
@@ -77,7 +77,7 @@ func (api APIClient) Query(quer string) ([]dataPoint, error) {
 
 func (api APIClient) trimQuery(q string) string {
 	space := regexp.MustCompile(`\s+`)
-	return space.ReplaceAllString(q, " ")
+	return space.ReplaceAllString(q, "")
 }
 
 type dataPoint struct {

diff --git a/metricproviders/graphite/api_test.go b/metricproviders/graphite/api_test.go
@@ -91,6 +91,29 @@ func TestQuery(t *testing.T) {
 		nil,
 		`[]`,
 		200,
+	}, {
+		"query with surrounding whitespace",
+		fmt.Sprintf("\n  %s \t  \n", query),
+		targetQuery,
+		fromQuery,
+		goodResult,
+		nil,
+		fmt.Sprintf(`[
+			{
+				"datapoints": [
+					[
+						%f,
+						%d
+					]
+				],
+				"target": " sumSeries(app.http.*.*.count)",
+				"tags": {
+					"aggregatedBy": "sum",
+					"name": "sumSeries(app.http.*.*.count)"
+				}
+			}
+		]`, value, timestamp),
+		200,
 	}, {
 		"graphite response body with invalid JSON",
 		query,