fix(argo-workflows): container and mainContainer imagePullPolicy #3126
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaptisteDeporte
requested review from
vladlosev,
jmeridth,
yu-croco and
tico24
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
I recently found a strange behaviour using argo-workflows chart. I use the following values :
But my controller config-map does not have the expecting output.
It seems that when we only set imagePullPolicy option for the mainContainer or the executor, it’s not applied.
I updated the Chart to something that seems to make more sense according to the doc
It’s my first contribution, I have read the CONTRIBUTING.md but any feedback is welcome !