-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(argo-rollouts): restart when configmap changes #3119
base: main
Are you sure you want to change the base?
feat(argo-rollouts): restart when configmap changes #3119
Conversation
Signed-off-by: Derek Brown <[email protected]>
{{/* Add the checksum of the ConfigMap to the annotations */}} | ||
{{/* This ensures that ConfigMap changes trigger a rolling update */}} | ||
configmap-checksum: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to align to other argoproj's checksum, and I don't think we need comments for this. :)
e.g.) https://github.com/argoproj/argo-helm/blob/main/charts/argo-cd/templates/argocd-application-controller/deployment.yaml#L24
Hi @DerekTBrown , thank you for your PR.
|
Signed-off-by: Derek Brown <[email protected]>
now I just wonder that the deployment of argo-rollouts doesn't refer configmap, how is the configmap related to deployment...? Do we need to restart as following configmap's change?🤔 |
I think there are potentially many config options that require a restart to take effect. To provide one example, plugins are configured via the ConfigMap and are downloaded on startup.1 If the user changes the ConfigMap to include or modify the plugin file or URL, they would expect the service to restart to pull in this change. Footnotes |
Context
Resolves #3118
Checklist: