Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argo-rollouts): restart when configmap changes #3119

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DerekTBrown
Copy link

@DerekTBrown DerekTBrown commented Jan 10, 2025

Context

Resolves #3118

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@DerekTBrown DerekTBrown changed the title feat: argo-rollouts restart when configmap changes feat(argo-rollouts): restart when configmap changes Jan 10, 2025
Comment on lines 34 to 36
{{/* Add the checksum of the ConfigMap to the annotations */}}
{{/* This ensures that ConfigMap changes trigger a rolling update */}}
configmap-checksum: {{ include (print $.Template.BasePath "/configmap.yaml") . | sha256sum }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to align to other argoproj's checksum, and I don't think we need comments for this. :)
e.g.) https://github.com/argoproj/argo-helm/blob/main/charts/argo-cd/templates/argocd-application-controller/deployment.yaml#L24

@yu-croco
Copy link
Collaborator

Hi @DerekTBrown , thank you for your PR.
Though you checked below on your PR description, I don't think you handle it. Please handle it.

I have updated the chart changelog with all the changes that come with this pull request according to changelog.

Signed-off-by: Derek Brown <[email protected]>
@DerekTBrown DerekTBrown requested a review from yu-croco January 13, 2025 17:13
@yu-croco
Copy link
Collaborator

now I just wonder that the deployment of argo-rollouts doesn't refer configmap, how is the configmap related to deployment...? Do we need to restart as following configmap's change?🤔
https://github.com/argoproj/argo-rollouts/blob/master/manifests/base/argo-rollouts-deployment.yaml

@DerekTBrown
Copy link
Author

now I just wonder that the deployment of argo-rollouts doesn't refer configmap, how is the configmap related to deployment...? Do we need to restart as following configmap's change?🤔 https://github.com/argoproj/argo-rollouts/blob/master/manifests/base/argo-rollouts-deployment.yaml

I think there are potentially many config options that require a restart to take effect.

To provide one example, plugins are configured via the ConfigMap and are downloaded on startup.1 If the user changes the ConfigMap to include or modify the plugin file or URL, they would expect the service to restart to pull in this change.

Footnotes

  1. https://argo-rollouts.readthedocs.io/en/stable/plugins/#plugin-name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] argo-rollouts should restart when changes are made to the configmap
2 participants