Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Quote MQTT example correctly #936

Merged
merged 2 commits into from
Nov 6, 2020
Merged

docs: Quote MQTT example correctly #936

merged 2 commits into from
Nov 6, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Nov 5, 2020 •
edited
Loading

Checklist:

  • Either (a) I've created an feature request and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@alexec alexec changed the title docs: Quote MQTT example correctl docs: Quote MQTT example correctly Nov 5, 2020
whynowy
whynowy approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexec alexec merged commit f10fc3a into master Nov 6, 2020
christophercutajar pushed a commit to christophercutajar/argo-events that referenced this pull request Nov 9, 2020
@alexec @christophercutajar
docs: Quote MQTT example correctly (argoproj#936)
da43f53 
Signed-off-by: christophercutajar <[email protected]>
whynowy pushed a commit to RiyaJohn/argo-events that referenced this pull request Nov 17, 2020
@alexec @whynowy
docs: Quote MQTT example correctly (argoproj#936)
2a52a9a 
Signed-off-by: Derek Wang <[email protected]>
@alexec alexec deleted the alexec-patch-2 branch December 3, 2020 22:57
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
@alexec
docs: Quote MQTT example correctly (argoproj#936)
5c95ae6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whynowy whynowy whynowy approved these changes

@VaibhavPage VaibhavPage Awaiting requested review from VaibhavPage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexec @whynowy