Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generic event source #895

Merged
merged 11 commits into from
Oct 12, 2020
Merged

feat: generic event source #895

merged 11 commits into from
Oct 12, 2020

Conversation

VaibhavPage
Copy link
Contributor

Checklist:

  • Either (a) I've created an feature request and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@VaibhavPage VaibhavPage reopened this Sep 26, 2020
@VaibhavPage VaibhavPage changed the title Feat/generic event source feat: generic event source Sep 26, 2020
@VaibhavPage VaibhavPage marked this pull request as ready for review September 27, 2020 17:44
whynowy
whynowy reviewed Sep 28, 2020
View reviewed changes
eventsources/eventing.go Show resolved Hide resolved
eventsources/sources/generic/start.go Outdated Show resolved Hide resolved
eventsources/sources/generic/start.go Outdated Show resolved Hide resolved
eventsources/sources/generic/start.go Outdated Show resolved Hide resolved
@VaibhavPage VaibhavPage marked this pull request as draft October 10, 2020 16:31
@VaibhavPage VaibhavPage marked this pull request as ready for review October 10, 2020 17:20
whynowy
whynowy reviewed Oct 12, 2020
View reviewed changes
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM expect 2 minor stuffs. We might need to figure out a way for auth later.

eventsources/sources/minio/start.go Outdated Show resolved Hide resolved
eventsources/sources/generic/start.go Outdated Show resolved Hide resolved
@VaibhavPage
Copy link
Contributor Author

LGTM expect 2 minor stuffs. We might need to figure out a way for auth later.

Yes, lets address that in a separate PR.

whynowy
whynowy approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VaibhavPage VaibhavPage merged commit 160657f into master Oct 12, 2020
whynowy pushed a commit to RiyaJohn/argo-events that referenced this pull request Nov 17, 2020
@VaibhavPage @whynowy
feat: generic event source (argoproj#895)
a238bfd 
* feat: added generic event source

* feat: updated types for generic eventsource

* fix: remove site folder

* fix: added eventsource in eventing

* fix: added logic to auto-connect for generic eventsource

* fix: added logic to auto-connect for generic eventsource

* chore: updated mkdocs for generic eventsource

* fix: typo

* fix: logging in minio

* fix: conn closing condition

* chore: generic es logging

Signed-off-by: Derek Wang <[email protected]>
@whynowy whynowy deleted the feat/generic-event-source branch February 25, 2021 23:19
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
@VaibhavPage
feat: generic event source (argoproj#895)
8eb3f79 
* feat: added generic event source

* feat: updated types for generic eventsource

* fix: remove site folder

* fix: added eventsource in eventing

* fix: added logic to auto-connect for generic eventsource

* fix: added logic to auto-connect for generic eventsource

* chore: updated mkdocs for generic eventsource

* fix: typo

* fix: logging in minio

* fix: conn closing condition

* chore: generic es logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magaldima magaldima magaldima left review comments

@whynowy whynowy whynowy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VaibhavPage @whynowy @magaldima