fix(eventbus): NATS eventbus auto reconnect and code refactory #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaibhavPage
suggested changes
Jul 17, 2020
| @@ -73,7 +71,16 @@ func NewNATSStreaming(url, clusterID, subject, clientID string, auth *Auth, logg | |||
|
|
|||
| func (n *natsStreaming) Connect() (Connection, error) { | |||
| log := n.logger.WithField("clientID", n.clientID) | |||
| opts := []nats.Option{} | |||
| opts := []nats.Option{ | |||
| nats.MaxReconnects(-1), | |||
There was a problem hiding this comment.
what's the significance of -1?
| @@ -261,7 +286,7 @@ func (e *EventSourceAdaptor) Start(ctx context.Context, stopCh <-chan struct{}) | |||
| return err | |||
| } | |||
| go func(s EventingServer) { | |||
| err := s.StartListening(cctx, stopCh, func(data []byte) error { | |||
| err := s.StartListening(cctx, func(data []byte) error { | |||
There was a problem hiding this comment.
You can now remove // TODO: Need Retry
VaibhavPage
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
()in sensor dependency expression was trimmed when converting group expr to dependency expr.a. utilize NATS reconnect feature - for short term connection lost such as NATS POD crash
b. Extra Goroutins in eventsource and sensor service to auto reconnect - for long term connection lost
ctx.Doneinstead ofstopCh