Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(documentation): use secret key referred in eventsource #698

Merged
merged 1 commit into from
Jun 14, 2020
Merged

fix(documentation): use secret key referred in eventsource #698

merged 1 commit into from
Jun 14, 2020

Conversation

vranystepan
Copy link
Contributor

apiVersion: v1
kind: Secret
metadata:
  name: github-access
type: Opaque
data:
  access: <base64-encoded-api-token-from-previous-step>

vs.

...
      # apiToken refers to K8s secret that stores the github api token
      apiToken:
        # Name of the K8s secret that contains the access token
        name: github-access
        # Key within the K8s secret whose corresponding value (must be base64 encoded) is access token
        key: token
...

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@VaibhavPage VaibhavPage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@VaibhavPage VaibhavPage merged commit df314d3 into argoproj:master Jun 14, 2020
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants