Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding support for multiple events in GitLab webhook #696

Merged
merged 7 commits into from
Jun 14, 2020
Merged

feat: adding support for multiple events in GitLab webhook #696

merged 7 commits into from
Jun 14, 2020

Conversation

VaibhavPage
Copy link
Contributor

No description provided.

@VaibhavPage VaibhavPage reopened this Jun 11, 2020
@VaibhavPage VaibhavPage marked this pull request as ready for review June 11, 2020 18:16
This was linked to issues Jun 11, 2020
Gitlab gateway always creates "PushEvents" #307
Closed
Gitlab webhook for multiple event types #678
Closed
@VaibhavPage VaibhavPage requested a review from whynowy June 11, 2020 18:24
@VaibhavPage VaibhavPage requested a review from whynowy June 11, 2020 19:23
whynowy
whynowy reviewed Jun 11, 2020
View reviewed changes
pkg/apis/eventsource/v1alpha1/types.go
// ProjectId is the id of project for which integration needs to setup
ProjectId string `json:"projectId" protobuf:"bytes,2,name=projectId"`
// ProjectID is the id of project for which integration needs to setup
ProjectID string `json:"projectID" protobuf:"bytes,2,name=projectID"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only the variable needs to be updated, the one in json doesn't need to be.

I just checked an example in kubernetes - https://github.com/kubernetes/kubernetes/blob/323f34858de18b862d43c40b2cced65ad8e24052/staging/src/k8s.io/legacy-cloud-providers/azure/auth/azure_auth.go#L50

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite confusing.... on the same file:

https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/legacy-cloud-providers/azure/auth/azure_auth.go#L72

https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/legacy-cloud-providers/azure/auth/azure_auth.go#L48

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to use ProjectID in variables, projectId in json:xxx, it looks like this is more than the other.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets start using projectID in json schema as well. I'll create another PR to update the Id mentioned in other event sources to ID

@VaibhavPage VaibhavPage requested a review from whynowy June 14, 2020 17:02
whynowy
whynowy approved these changes Jun 14, 2020
View reviewed changes
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VaibhavPage VaibhavPage merged commit 82cb830 into master Jun 14, 2020
@whynowy whynowy deleted the feat/allow-multiple-gitlab-events branch February 25, 2021 23:17
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
@VaibhavPage
feat: adding support for multiple events in GitLab webhook (argoproj#696
f263646 
)

* feat: adding support for multiple events in GitLab webhook

* chore: fixing build error

* chore: fixing test error

* chore: reverting back to travis until we fix circle ci memory issue

* chore: remove defunct dockerfile

* fix: gitlab event source events

* fix: rename project id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whynowy whynowy whynowy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gitlab webhook for multiple event types Gitlab gateway always creates "PushEvents"
2 participants
@VaibhavPage @whynowy