Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added namespace to create obj #385

Merged
merged 2 commits into from
Oct 21, 2019
Merged

added namespace to create obj #385

merged 2 commits into from
Oct 21, 2019

Conversation

smolaon
Copy link
Contributor

@smolaon smolaon commented Oct 21, 2019

Passing namespace to dynamicResInterface.Create method.

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

VaibhavPage
VaibhavPage approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@VaibhavPage VaibhavPage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

@VaibhavPage VaibhavPage merged commit f9fa18b into argoproj:master Oct 21, 2019
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
@smolaon @VaibhavPage
added namespace to create obj (argoproj#385)
fefe096
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaibhavPage VaibhavPage VaibhavPage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smolaon @CLAassistant @VaibhavPage