Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add git to argo-events image #3244

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tdenmon
Copy link

@tdenmon tdenmon commented Aug 16, 2024

This commit adds git to the argo-events Docker image, which is required in order to use Git as a source for a Sensor.

Fixes #3065

Checklist:

@tdenmon tdenmon marked this pull request as ready for review August 16, 2024 21:32
@tdenmon tdenmon requested a review from whynowy as a code owner August 16, 2024 21:32
Copy link
Author

@tdenmon tdenmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying the relevant linked libraries is not my ideal solution here, but as git is dynamically linked in the apk package it's either this or cloning down the git source code and manually building it statically linked.

This is the far faster solution. I'm open to suggestions/pushback here though.

@whynowy
Copy link
Member

whynowy commented Aug 29, 2024

The git binary was even before my time. But I don't think we need it in the image - we use go-git lib, and it worked before. It went to a bad state due to some unknown changes. Need investigation.

@tdenmon
Copy link
Author

tdenmon commented Aug 30, 2024

The git binary was even before my time. But I don't think we need it in the image - we use go-git lib, and it worked before. It went to a bad state due to some unknown changes. Need investigation.

Could be related to go-git #838? There's a refactor PR to explicitly drop any dependency on an external git binary.

@whynowy
Copy link
Member

whynowy commented Sep 10, 2024

The git binary was even before my time. But I don't think we need it in the image - we use go-git lib, and it worked before. It went to a bad state due to some unknown changes. Need investigation.

Could be related to go-git #838? There's a refactor PR to explicitly drop any dependency on an external git binary.

Probably...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using git as a source for k8s trigger: git executable not found
2 participants