-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add git to argo-events image #3244
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: tdenmon <[email protected]>
Signed-off-by: tdenmon <[email protected]>
Signed-off-by: tdenmon <[email protected]>
…s-image' into add-git-to-argo-events-image
Signed-off-by: tdenmon <[email protected]>
Signed-off-by: tdenmon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copying the relevant linked libraries is not my ideal solution here, but as git
is dynamically linked in the apk package it's either this or cloning down the git
source code and manually building it statically linked.
This is the far faster solution. I'm open to suggestions/pushback here though.
The |
Could be related to go-git #838? There's a refactor PR to explicitly drop any dependency on an external git binary. |
Probably... |
This commit adds
git
to the argo-events Docker image, which is required in order to use Git as a source for a Sensor.Fixes #3065
Checklist: