fix: fix bug in evaluation of filters with filtersLogicalOperator=or #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvk
force-pushed
the
fix-filterlogicaloperator-or-with-subset-of-filters
branch
from
ba7cee5
to
12b246a
Compare
Signed-off-by: jsvk <[email protected]>
jsvk
force-pushed
the
fix-filterlogicaloperator-or-with-subset-of-filters
branch
from
12b246a
to
4cc7f1d
Compare
Signed-off-by: jsvk <[email protected]>
Signed-off-by: jsvk <[email protected]>
bilalba
pushed a commit
to intuit-data-os/argo-events
that referenced
this pull request
Jan 9, 2023
…rgoproj#2374) Signed-off-by: jsvk <[email protected]> Signed-off-by: Bilal Bakht Ahmad <[email protected]>
whynowy
pushed a commit
that referenced
this pull request
Jan 17, 2023
…2374) Signed-off-by: jsvk <[email protected]>
jwillker
pushed a commit
to jwillker/argo-events
that referenced
this pull request
Mar 29, 2023
…rgoproj#2374) Signed-off-by: jsvk <[email protected]> Signed-off-by: JohnWillker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
This PR fixes a bug where when specifying only a subset of filters, in our case an expr filter and data filter, the filter would always evaluate to a 'pass'ing condition.
This happens because the code doesn't check that we specified a filter before attempting to evaluate it, at which point it will default to
true.The PR changes that behavior to check if the filter was
nilbefore looking at what it evaluates to.