fix: adds SigningCertURL validation for SNS messages #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aweis89
changed the title
aweis89
force-pushed
the
master
branch
2 times, most recently
from
0ef864a
to
dcd6a1c
Compare
Signed-off-by: Aaron Weisberg <[email protected]>
Signed-off-by: Aaron Weisberg <[email protected]>
whynowy
approved these changes
Feb 15, 2022
whynowy
pushed a commit
that referenced
this pull request
Feb 16, 2022
* fix: adds regex & schema checks to SigningCertURL Signed-off-by: Aaron Weisberg <[email protected]>
BulkBeing
pushed a commit
to BulkBeing/argo-events
that referenced
this pull request
Mar 7, 2022
* fix: adds regex & schema checks to SigningCertURL Signed-off-by: Aaron Weisberg <[email protected]>
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
* fix: adds regex & schema checks to SigningCertURL Signed-off-by: Aaron Weisberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the SigningCertURL is part of the HTTP request body, I don't see where we're validating that the cert URL is indeed valid and from AWS before retrieving the cert here. Here's an example of this being done in the .net SDK but I don't see that happening in the Golang SDK anywhere.
This PR adds that validation check explicitly.
Checklist: