-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Creation of ingress resource with k8s trigger #1434
fix: Creation of ingress resource with k8s trigger #1434
Conversation
Signed-off-by: Daniel Soifer <[email protected]>
Fixes: #1432 |
Signed-off-by: Daniel Soifer <[email protected]>
Signed-off-by: Daniel Soifer <[email protected]>
Signed-off-by: Daniel Soifer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
Per @alexec (who is from England) - plural of |
@whynowy Oh I see.. Well I'm certainly not an English expert but from a quick Google search, it seems like |
* fix: Creation of ingress resource with k8s trigger Signed-off-by: Daniel Soifer <[email protected]> * used plural namer lib Signed-off-by: Daniel Soifer <[email protected]> * added another test Signed-off-by: Daniel Soifer <[email protected]> * codegen Signed-off-by: Daniel Soifer <[email protected]>
I think it would be weird to support both - an extra CRD for |
@whynowy Yes, definitely, an extra CRD would be weird. I actually meant either adding an exception like you suggested, or changing the plural form of the existing CRD back to eventbuses so we can stick to the conventions and also get rid of that extra logic that was added to the codegen process, of transforming eventbuses to eventbus |
@daniel-codefresh - I prefer to add exceptions, changing CRD definition sometimes brings weird issues during upgrade. Code-gen used to support exceptions, not sure why it is not supporting now. I didn't spent time on the research. |
@whynowy Oh yea, now I see what you meant by codegen exceptions.. I was thinking about using a plural exception for |
* fix: Creation of ingress resource with k8s trigger Signed-off-by: Daniel Soifer <[email protected]> * used plural namer lib Signed-off-by: Daniel Soifer <[email protected]> * added another test Signed-off-by: Daniel Soifer <[email protected]> * codegen Signed-off-by: Daniel Soifer <[email protected]>
* fix: Creation of ingress resource with k8s trigger Signed-off-by: Daniel Soifer <[email protected]> * used plural namer lib Signed-off-by: Daniel Soifer <[email protected]> * added another test Signed-off-by: Daniel Soifer <[email protected]> * codegen Signed-off-by: Daniel Soifer <[email protected]>
Signed-off-by: Daniel Soifer [email protected]
Checklist: