feat: trigger rate limit. Closes: #1087 #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
whynowy
commented
Aug 23, 2021
| func (sensorCtx *SensorContext) triggerOne(ctx context.Context, sensor *v1alpha1.Sensor, trigger v1alpha1.Trigger, eventsMapping map[string]*v1alpha1.Event, depNames, eventIDs []string, log *zap.SugaredLogger) error { | ||
| defer func(start time.Time) { | ||
| sensorCtx.metrics.ActionDuration(sensor.Name, trigger.Template.Name, float64(time.Since(start)/time.Millisecond)) | ||
| }(time.Now()) | ||
|
|
||
| defer sensorCtx.metrics.ActionDuration(sensor.Name, trigger.Template.Name, float64(time.Since(time.Now())/time.Millisecond)) |
There was a problem hiding this comment.
Duplicate, incorrect metrics.
|
|
||
| type RateLimit struct { | ||
| // Defaults to Second | ||
| Unit RateLimiteUnit `json:"unit,omitempty" protobuf:"bytes,1,opt,name=unit"` |
There was a problem hiding this comment.
can't you use Duration here?
There was a problem hiding this comment.
Using Duration like below seems to be weird:
spec:
triggers:
- rateLimit:
duration: 5s
requests: 20Referencing to Istio and ambassador, both of them use unit:
Istio:
apiVersion: v1
kind: ConfigMap
metadata:
name: ratelimit-config
data:
config.yaml: |
domain: productpage-ratelimit
descriptors:
- key: PATH
value: "/productpage"
rate_limit:
unit: minute
requests_per_unit: 1
- key: PATH
rate_limit:
unit: minute
requests_per_unit: 100Ambassador:
apiVersion: getambassador.io/v2
kind: RateLimit
metadata:
name: backend-rate-limit
spec:
domain: ambassador
limits:
- pattern: [{generic_key: backend}]
rate: 3
unit: minute
sarabala1979
approved these changes
Aug 23, 2021
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
* feat: trigger rate limit. Closes: argoproj#1087 Signed-off-by: Derek Wang <[email protected]> * ok Signed-off-by: Derek Wang <[email protected]> * lint Signed-off-by: Derek Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Wang [email protected]
Trigger supports rate limit:
Closes: #1087
Checklist: