fix: Trim newline of the content read from Secrets or Configmaps

[whynowy]

Signed-off-by: Derek Wang [email protected]

Secrets edited by tools like vim always have an invisible \n in the end, and it is often neglected by the user, however this makes differences for some of the applications. We trim that \n to avoid issues.

Also upgraded go-git package to the latest.

Fixes: #338

Might fix: #1068 as well.
Checklist:

• My organization is added to USERS.md.

[alexec]

are we saying go 16 is broken?

[whynowy]

are we saying go 16 is broken?

are we saying go 16 is broken?

I take back what I said, it's NOT an issue of ioutil.ReadFile() or os.ReadFile(), this is actually an issue of vim.

We always use vim to create a credential file on the local, and then use kubectl create secret xxx --from-file=xxx to create k8s secrets. However, vi or vim always put newlines (\n) at the end of every line - especially including the last line. This newline is not a visible new line, but it does have an \n there.

For example:

vi test1.txt with a string hello and :wq, you will see the file size is 6 instead of 5, the extra 1 is invisible \n, though you don't see a new line with cat test1.txt.

If you do the same thing with another file text2.txt, but do :set binary, :set noeol before :wq, the file size will be 5 indeed.

https://unix.stackexchange.com/questions/31807/what-does-the-noeol-indicator-at-the-bottom-of-a-vim-edit-session-mean

Here we still trim the ending \n in our code to avoid issues.