Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 1028 - Not able to send message to slack private channel #1036

Merged
merged 1 commit into from
Jan 25, 2021
Merged

fix: 1028 - Not able to send message to slack private channel #1036

merged 1 commit into from
Jan 25, 2021

Conversation

shashwat-appdirect
Copy link
Contributor

@shashwat-appdirect shashwat-appdirect commented Jan 25, 2021

Checklist:

Fixes: #1028

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2021

CLA assistant check
All committers have signed the CLA.

@shashwat-appdirect shashwat-appdirect changed the title [1028] : Not able to send message to slack private channel fix: 1028 - Not able to send message to slack private channel Jan 25, 2021
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@whynowy whynowy merged commit 24a0115 into argoproj:master Jan 25, 2021
whynowy pushed a commit that referenced this pull request Jan 26, 2021
@shashwat-appdirect shashwat-appdirect deleted the bug-1028 branch January 27, 2021 04:55
@shashwat-appdirect
Copy link
Contributor Author

shashwat-appdirect commented Jan 27, 2021

Hi @whynowy,
I tested it using curl with the latest v1.2.1, but seems that the issue is still there. And this time I am getting a different error. For public channel it is working whereas for private it is failing with below error:

2021/01/27 09:35:01 protocol error: received *http.http2GoAwayFrame before a SETTINGS frame {"level":"error","ts":1611740101.401435,"logger":"argo-events.sensor","caller":"slack/slack.go:118","msg":"unable to list channels","sensorName":"webhook","error":"Post \"https://slack.com/api/conversations.list\": connection error: PROTOCOL_ERROR","stacktrace":"github.com/argoproj/argo-events/sensors/triggers/slack.(*SlackTrigger).Execute\n\t/home/runner/work/argo-events/argo-events/sensors/triggers/slack/slack.go:118\ngithub.com/argoproj/argo-events/sensors.(*SensorContext).triggerActions\n\t/home/runner/work/argo-events/argo-events/sensors/listener.go:267\ngithub.com/argoproj/argo-events/sensors.(*SensorContext).ListenEvents.func1.3\n\t/home/runner/work/argo-events/argo-events/sensors/listener.go:158"} {"level":"error","ts":1611740101.403081,"logger":"argo-events.sensor","caller":"sensors/listener.go:160","msg":"failed to trigger actions","sensorName":"webhook","error":"failed to list channels: Post \"https://slack.com/api/conversations.list\": connection error: PROTOCOL_ERROR","errorVerbose":"Post \"https://slack.com/api/conversations.list\": connection error: PROTOCOL_ERROR\nfailed to list channels\ngithub.com/argoproj/argo-events/sensors/triggers/slack.(*SlackTrigger).Execute\n\t/home/runner/work/argo-events/argo-events/sensors/triggers/slack/slack.go:119\ngithub.com/argoproj/argo-events/sensors.(*SensorContext).triggerActions\n\t/home/runner/work/argo-events/argo-events/sensors/listener.go:267\ngithub.com/argoproj/argo-events/sensors.(*SensorContext).ListenEvents.func1.3\n\t/home/runner/work/argo-events/argo-events/sensors/listener.go:158\nruntime.goexit\n\t/opt/hostedtoolcache/go/1.14.13/x64/src/runtime/asm_amd64.s:1373","stacktrace":"github.com/argoproj/argo-events/sensors.(*SensorContext).ListenEvents.func1.3\n\t/home/runner/work/argo-events/argo-events/sensors/listener.go:160"}

Now it is not able to list the channels itself. I debugged and found that the fix which we merge might have something wrong:
We merged the below:
Types: []string{"public_channel,private_channel"},
whereas I think it should be as :
Types: []string{"public_channel","private_channel"},

Note the 2 words are the two different strings. Please suggest if my understanding is correct and we need a change. I have raised a PR for your review in case my understanding is correct - #1038

Thanks a lot!

juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to send message to slack private channel
3 participants