Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support imagePullSecrets for custom resources #946

Closed
nfickas opened this issue Nov 10, 2020 · 0 comments · Fixed by #947
Closed

Support imagePullSecrets for custom resources #946

nfickas opened this issue Nov 10, 2020 · 0 comments · Fixed by #947
Labels
enhancement New feature or request
Milestone

Comments

@nfickas
Copy link

nfickas commented Nov 10, 2020

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Due to docker hub's rate limiting we would like to pull the argo-events images into our private registry. To do this we need to be able to set the imagePullSecrets on the different custom resources so the images are able to be pulled.

Describe the solution you'd like
A clear and concise description of what you want to happen.

imagePullSecrets to be passed through to the EventSource and Sensor pods.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@nfickas nfickas added the enhancement New feature or request label Nov 10, 2020
@whynowy whynowy added this to the v1.2 milestone Nov 10, 2020
whynowy added a commit to whynowy/argo-events that referenced this issue Nov 10, 2020
juliev0 pushed a commit to juliev0/argo-events that referenced this issue Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants