We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug
If jsonBody is not true, payload from the GRPC server is ignored.
jsonBody
payload
eventData := &events.GenericEventData{ Metadata: el.GenericEventSource.Metadata, } if el.GenericEventSource.JSONBody { eventData.Body = (*json.RawMessage)(&event.Payload) } eventBytes, err := json.Marshal(eventData)
To Reproduce Steps to reproduce the behavior:
Expected behavior A clear and concise description of what you expected to happen.
Screenshots If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):
Additional context Add any other context about the problem here.
Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.
The text was updated successfully, but these errors were encountered:
fix(generic-eventsource): Set payload when jsonbody is not true. Fixes …
936ecd9
…argoproj#930
c446bad
…#930 (#931)
2698d12
…argoproj#930 (argoproj#931) Signed-off-by: Derek Wang <[email protected]>
584cc37
…argoproj#930 (argoproj#931)
Successfully merging a pull request may close this issue.
Describe the bug
If
jsonBody
is not true,payload
from the GRPC server is ignored.To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):
Additional context
Add any other context about the problem here.
Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.
The text was updated successfully, but these errors were encountered: