Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic EventSource does not set payload when jsonBody is not true #930

Closed
whynowy opened this issue Oct 29, 2020 · 0 comments · Fixed by #931
Closed

Generic EventSource does not set payload when jsonBody is not true #930

whynowy opened this issue Oct 29, 2020 · 0 comments · Fixed by #931
Labels
bug Something isn't working
Milestone

Comments

@whynowy
Copy link
Member

whynowy commented Oct 29, 2020

Describe the bug

If jsonBody is not true, payload from the GRPC server is ignored.

					eventData := &events.GenericEventData{
						Metadata: el.GenericEventSource.Metadata,
					}
					if el.GenericEventSource.JSONBody {
						eventData.Body = (*json.RawMessage)(&event.Payload)
					}
					eventBytes, err := json.Marshal(eventData)

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • Kubernetes: [e.g. v1.18.6]
  • Argo: [e.g. v2.9.4]
  • Argo Events: [e.g. v1.0.0]

Additional context
Add any other context about the problem here.


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant