Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better approach to deal with ~/.ssh/known_hosts for triggers pulling resources from git. #841

Closed
whynowy opened this issue Aug 19, 2020 · 0 comments · Fixed by #842
Closed
Labels
enhancement New feature or request

Comments

@whynowy
Copy link
Member

whynowy commented Aug 19, 2020

Is your feature request related to a problem? Please describe.
To trigger a workflow or k8s resource with source from github, if git URL is configured as "git://xxxxx", it requires ~/.ssh/known_hosts is configured, which means following spec is needed currently.

spec:
  template:
    container:
      volumeMounts:
        - mountPath: /etc/ssh
          name: known-hosts
    volumes:
      # The name of the key in the secret must be "ssh_known_hosts"
      # Make sure you have your git provider added in the known hosts
      # e.g. create the secret by running, kubectl -n argo-events create secret generic git-known-hosts --from-file=ssh_known_hosts=.ssh/known_hosts
      - name: known-hosts
        secret:
          secretName: git-known-hosts

Describe the solution you'd like

  1. Ignore the host key check;

  2. If approach 1 is not doable, add a filed (secretKeySelector) for known_hosts to git trigger, so that user don't need to mount the volume with spec.template.container.volumes


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@whynowy whynowy added the enhancement New feature or request label Aug 19, 2020
whynowy added a commit to whynowy/argo-events that referenced this issue Aug 20, 2020
VaibhavPage pushed a commit that referenced this issue Aug 20, 2020
* feat: Connect to git with InsecureIgnoreHostKey. Closes #841

* fix test case failure
whynowy added a commit that referenced this issue Aug 20, 2020
* feat: Connect to git with InsecureIgnoreHostKey. Closes #841

* fix test case failure
juliev0 pushed a commit to juliev0/argo-events that referenced this issue Mar 29, 2022
…rgoproj#842)

* feat: Connect to git with InsecureIgnoreHostKey. Closes argoproj#841

* fix test case failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant